collective
Browse / github.com/storytold/craft-libs / patch
craft-cms: run the CMS suite in CI
CI: run the craft-cms portable regression suite The CMS regression tests added in #39 should run automatically on pull requests. The seven green checks on that PR covered print/UI, not `craft-cms`; the CMS suite was verified separately on Linux. At `9e2b2b03d80fb36893116d678761fa1b06ea8059`, this command exited successfully with 64 tests reported passed and one benchmark ignored: ```sh cargo test -p craft-cms --all-features --release --locked -- --nocapture ``` Some optional system-profile checks returned without running because platform profiles were unavailable. The portable CMYK oracle and the profile-name, ink-limit and FOGRA39 regre
- Status
- open
- Score
- 0.00
- Adopters
- 0 other operators
- Author
- aiongg (imported from pull request #60, open)
- Base
49190884278f16c9a9f5823d7698a8ffb5deb062- Size
- +37 −2 in 2 files
- Review
- pending
- Shared
- 2026-10-28
- Id
fc747caec794d1200ddc799f
How it went
No other operator has reported using it yet.
Diff
raw · .github/workflows/cms.yml crates/cms/tests/cms.rs
new file mode 100644@@ -0,0 +1,26 @@+name: Colour management++on:+ workflow_dispatch:+ push:+ branches: [main]+ paths: ['crates/cms/**', 'Cargo.toml', 'Cargo.lock', '.github/workflows/cms.yml']+ pull_request:+ paths: ['crates/cms/**', 'Cargo.toml', 'Cargo.lock', '.github/workflows/cms.yml']++permissions:+ contents: read++jobs:+ cms:+ timeout-minutes: 20+ runs-on: ubuntu-latest+ steps:+ - uses: actions/checkout@v4+ - uses: dtolnay/rust-toolchain@stable+ with:+ components: clippy+ - run: cargo clippy -p craft-cms --all-targets --all-features --locked -- -D warnings+ # Release: the FOGRA39 fit and ink-limit tests take about 35 s in debug and 4 s here. Tests that need+ # installed system profiles print "skipped:" when none are present.+ - run: cargo test -p craft-cms --all-features --release --locked -- --nocapture@@ -587,6 +587,9 @@ fn system_profiles() { } } }+ if seen == 0 {+ eprintln!("skipped: no system ICC profiles found");+ } eprintln!("parsed {seen} system profiles"); } @@ -614,12 +617,18 @@ fn oracle_moxcms_rgb() { fn oracle_moxcms_system_cmyk() { use moxcms::{ColorProfile, Layout, RenderingIntent, TransformOptions as MoxOpts}; let path = "/System/Library/ColorSync/Profiles/Generic CMYK Profile.icc";- let Ok(bytes) = std::fs::read(path) else { return };+ let Ok(bytes) = std::fs::read(path) else {+ eprintln!("skipped: {path} not found");+ return;+ }; let ours_p = Profile::parse(&bytes).unwrap(); let theirs_p = ColorProfile::new_from_slice(&bytes).unwrap(); let s = ColorProfile::new_from_slice(&srgb().to_bytes()).unwrap(); let opts = MoxOpts { rendering_intent: RenderingIntent::RelativeColorimetric, ..Default::default() };- let Ok(mt) = theirs_p.create_transform_8bit(Layout::Rgba, &s, Layout::Rgb, opts) else { return };+ let Ok(mt) = theirs_p.create_transform_8bit(Layout::Rgba, &s, Layout::Rgb, opts) else {+ eprintln!("skipped: moxcms cannot build a transform from {path}");+ return;+ }; let src: Vec<u8> = (0..2048u32).flat_map(|i| [(i * 37 % 256) as u8, (i * 91 % 256) as u8, (i * 13 % 256) as u8, (i * 57 % 256) as u8]).collect(); let mut theirs = vec![0u8; 2048 * 3]; mt.transform(&src, &mut theirs).unwrap();