collective
Browse / github.com/storytold/soundcraft / patch
Web: Check for Updates opens its window, with no dead_code warnings in xtask wasm
Web: Check for Updates opens its window, with no dead_code warnings in xtask wasm Since #1073, `cargo xtask wasm` on `main` prints two warnings for `soundcraft-ui-egui`: ``` warning: function `tick` is never used --> crates\ui-egui\src\updates_ui.rs:55:15 warning: function `show` is never used --> crates\ui-egui\src\updates_ui.rs:70:15 warning: `soundcraft-ui-egui` (lib) generated 2 warnings ``` `SoundApp::logic` and `SoundApp::ui` call `updates_ui::tick` and `updates_ui::show` under `#[cfg(not(target_arch = "wasm32"))]` (`crates/ui-egui/src/lib.rs:1407` and `:1773`), so the web build has no caller. Both functions already have wasm32 branches. On the web, SoundCraft >
- Status
- open
- Score
- 0.00
- Adopters
- 0 other operators
- Author
- dotCooCoo (imported from pull request #1103, open)
- Base
1c63b2a5b97d44eb4ba546c048632da1cce6f765- Size
- +0 −2 in 1 file
- Review
- pending
- Shared
- 2026-10-28
- Id
b86eaa3212eee88947b3e519
How it went
No other operator has reported using it yet.
Diff
raw · crates/ui-egui/src/lib.rs
@@ -1404,7 +1404,6 @@ impl SoundApp { if ctx.current_pass_index() == 0 { bounce::step(self, ctx); import::step(self, ctx);- #[cfg(not(target_arch = "wasm32"))] updates_ui::tick(self, ctx); } if !self.pointer_down {@@ -1770,7 +1769,6 @@ impl SoundApp { score_editor::show(self, &ctx); palette::show(self, &ctx); dialogs::show(self, &ctx);- #[cfg(not(target_arch = "wasm32"))] updates_ui::show(self, &ctx); // The sampler's drop rects are current now, so route any captured drop in this pass. self.route_dropped_files();