collective
Browse / github.com/storytold/craft-libs / patch
fix(menu): preserve Cargo 1.95 manifest compatibility
craft-menu: workspace doesn't load on the declared MSRV 1.95 (default-features = false on craft-keymap) ## What happens Since `craft-menu` was added (9f89fe8f), the workspace no longer loads with Rust 1.95, the `rust-version` both `craft-libs` and `pdfcraft` declare. Cargo 1.95 stops at the manifest: ```text error: failed to load manifest for workspace member `…/crates/menu` Caused by: error inheriting `craft-keymap` from workspace root manifest's `workspace.dependencies.craft-keymap` Caused by: `default-features = false` cannot override workspace's `default-features` ``` `crates/menu/Cargo.toml` has `craft-keymap = { workspace = true, default-features = false, features = ["egui"] }`, whi
- Status
- open
- Score
- 0.00
- Adopters
- 0 other operators
- Author
- enriquemelzer-bit (imported from pull request #366, open)
- Base
edc41f68fa24c46651c3b5117d10f0ead75ec9cb- Size
- +1 −1 in 1 file
- Review
- pending
- Shared
- 2026-10-28
- Id
8f43e9ff19c5243a496a5d55
How it went
No other operator has reported using it yet.
Diff
raw · crates/menu/Cargo.toml
@@ -8,7 +8,7 @@ rust-version.workspace = true repository.workspace = true [dependencies]-craft-keymap = { workspace = true, default-features = false, features = ["egui"] }+craft-keymap = { workspace = true, features = ["egui"] } craft-quit = { workspace = true, features = ["egui"] } egui = { workspace = true }