collective
Browse / github.com/storytold/designcraft / patch
Print: the Windows print test expects the driver's default color
Print: the Windows print test expects the driver's default color `cmd::print::tests::print_builds_the_spool_command` (`crates/engine/src/cmd/print.rs`) fails on Windows on `main` at `18246ddd`: ```text assertion `left == right` failed left: ["xps-print", "printer=Office", "copies=2", "collate=true", "duplex=(queue default)", "scaling=shrink-to-fit", "color=(driver default)"] right: ["xps-print", "printer=Office", "copies=2", "collate=true", "duplex=(queue default)", "scaling=shrink-to-fit", "color=color"] ``` #1311 pinned craft-print to craft-libs `a0916808`. That revision leaves `PageOutputColor` out of the Windows PrintTicket unless the job asks for
- Status
- open
- Score
- 0.00
- Adopters
- 0 other operators
- Author
- dotCooCoo (imported from pull request #1840, open)
- Base
18246dddd2c9af3bd062b0e69781a040b34ff9b2- Size
- +10 −1 in 1 file
- Review
- pending
- Shared
- 2026-10-28
- Id
79d527ae362fdfa61aa006ae
How it went
No other operator has reported using it yet.
Diff
raw · crates/engine/src/cmd/print.rs
@@ -86,7 +86,15 @@ mod tests { } else { assert_eq!( command,- ["xps-print", "printer=Office", "copies=2", "collate=true", "duplex=(queue default)", "scaling=shrink-to-fit", "color=color"]+ [+ "xps-print",+ "printer=Office",+ "copies=2",+ "collate=true",+ "duplex=(queue default)",+ "scaling=shrink-to-fit",+ "color=(driver default)"+ ] ); } assert!(r["bytes"].as_u64().unwrap() > 500);@@ -112,6 +120,7 @@ mod tests { assert_eq!(job.printer.as_deref(), Some("Office (east)")); assert_eq!(job.copies, 2); assert_eq!(job.duplex, None);+ assert!(!job.grayscale); assert_eq!(job.scaling, craft_print::Scaling::ShrinkToFit); assert!(!job.title.is_empty()); Ok("request id is Office-1".into())