collective
Browse / github.com/storytold/lightcraft / patch
Issue #3070: the CLI's refused-connection tests use a free port, not 18437
CLI tests hardcode port 18437, inside the range AGENTS.md gives agents' control servers Part of #3057. ## Summary The CLI tests that check the "nothing is listening" message connect to port 18437 and assume nothing is listening there. AGENTS.md tells parallel agents to give their app's control server a port in 18000–19999. If one picked 18437: - the test would send `ui.inspect` to a running app and fail; - or it would drive that app. ## Evidence (main bb08a697) - **`apps/lightcraft-cli/tests/it/cli.rs:610`:** `run_cli(&["--connect", "127.0.0.1:18437", "ui.inspect"], None)`. The same assumption is at `:623` (`--connect 18437`), and the message check at `:612` names `--control
- Status
- open
- Score
- 0.00
- Adopters
- 0 other operators
- Author
- THEtheChad (imported from pull request #3098, open)
- Base
bb08a697a41b2561a54f1b740245119503b24758- Size
- +23 −8 in 1 file
- Review
- pending
- Shared
- 2026-10-28
- Id
16dd8c5a3437d8abc3ff833a
How it went
No other operator has reported using it yet.
Diff
raw · apps/lightcraft-cli/tests/it/cli.rs
@@ -495,6 +495,18 @@ fn snapshot_starts_without_a_gpu() { } } +/// A loopback port nothing listens on, for tests that need `--connect` to be refused (#3070).+/// A fixed port is not safe: agents give their apps' control servers ports in 18000–19999 (and+/// 7980 is the default), so a test could reach someone's running app and drive it. The OS hands+/// out a free port for `:0`; the listener is dropped so connecting to it is refused. Another+/// process could bind the port between the drop and the connect. That window is a few+/// milliseconds, and `:0` draws from the OS's ephemeral range (from 32768 on Linux, 49152 on+/// macOS and Windows), where nobody puts a control server (7980, 18000–19999): the standard+/// trade-off for a test that needs a refused connection.+fn unused_port() -> u16 {+ std::net::TcpListener::bind("127.0.0.1:0").unwrap().local_addr().unwrap().port()+}+ fn run_cli(args: &[&str], stdin: Option<&str>) -> (bool, Vec<Value>, String) { let mut child = Command::new(BIN).arg("run").args(args).stdin(Stdio::piped()).stdout(Stdio::piped()).stderr(Stdio::piped()).spawn().unwrap(); if let Some(text) = stdin {@@ -607,9 +619,10 @@ fn a_library_open_in_another_process_is_refused() { /// ADDR actually names — following the old fixed "7980" left the retry connecting elsewhere. #[test] fn connect_failure_hint_names_the_attempted_port() {- let (ok, _lines, err) = run_cli(&["--connect", "127.0.0.1:18437", "ui.inspect"], None);+ let port = unused_port();+ let (ok, _lines, err) = run_cli(&["--connect", &format!("127.0.0.1:{port}"), "ui.inspect"], None); assert!(!ok);- assert!(err.contains("--control 18437"), "the hint must name the port it tried: {err}");+ assert!(err.contains(&format!("--control {port}")), "the hint must name the port it tried: {err}"); assert!(!err.contains("--control 7980"), "{err}"); } @@ -619,20 +632,22 @@ fn connect_failure_hint_names_the_attempted_port() { /// works; non-numeric, non-`ADDR`-shaped tokens (e.g. a real command id) keep falling through. #[test] fn connect_bare_port_is_treated_as_loopback_port() {+ let port = unused_port();+ let hint = format!("--control {port}"); // Bare port: the failure hint names that port.- let (ok, _lines, err) = run_cli(&["--connect", "18437", "ui.inspect"], None);+ let (ok, _lines, err) = run_cli(&["--connect", &port.to_string(), "ui.inspect"], None); assert!(!ok);- assert!(err.contains("--control 18437"), "bare port must reach the hint: {err}");+ assert!(err.contains(&hint), "bare port must reach the hint: {err}"); assert!(!err.contains("--control 7980"), "{err}"); // `<host>:<port>` still works (issue #167 case).- let (ok, _lines, err) = run_cli(&["--connect", "127.0.0.1:18437", "ui.inspect"], None);+ let (ok, _lines, err) = run_cli(&["--connect", &format!("127.0.0.1:{port}"), "ui.inspect"], None); assert!(!ok);- assert!(err.contains("--control 18437"), "{err}");+ assert!(err.contains(&hint), "{err}"); // `--connect=<bare-port>` already worked (the `a.starts_with("--connect=")` arm); spot-check // the hint matches its port too.- let (ok, _lines, err) = run_cli(&["--connect=18437", "ui.inspect"], None);+ let (ok, _lines, err) = run_cli(&[&format!("--connect={port}"), "ui.inspect"], None); assert!(!ok);- assert!(err.contains("--control 18437"), "{err}");+ assert!(err.contains(&hint), "{err}"); } /// The CLI logs warnings on stderr (#168): with `RUST_LOG=warn` an unknown GPU backend name is