collective
Browse / github.com/storytold/filmcraft / patch
fix(engine): import index_folder only where its unix-only test uses it
fix(engine): import index_folder only where its unix-only test uses it ## Summary `crates/engine/src/relink_tests.rs` imported `index_folder` unconditionally, but the only test that uses it is `#[cfg(unix)]`. On Windows the test is compiled out, the import is unused, and `cargo clippy --workspace --all-targets -- -D warnings` fails. The import is now under `#[cfg(unix)]`; `apply_remap` and `derive_remap` stay unconditional. ## Testing (Windows 11) - `cargo fmt --all --check`: clean - `cargo clippy -p filmcraft-engine --all-targets -- -D warnings`: clean (failed before) - `cargo test -p filmcraft-engine --lib relink`: 15 passed 🤖 Generated with [Claude Code](ht
- Status
- open
- Score
- 0.00
- Adopters
- 0 other operators
- Author
- sarayunova (imported from pull request #3311, open)
- Base
20f02b9aa1c7b06f8837e2ff8e469c43f198e7a4- Size
- +3 −1 in 1 file
- Review
- pending
- Shared
- 2026-10-28
- Id
0c1f0626bd2e9fa41501d692
How it went
No other operator has reported using it yet.
Diff
raw · crates/engine/src/relink_tests.rs
@@ -9,7 +9,9 @@ use serde_json::json; use crate::Session; use crate::media_test_util::{frame_rgba, make_movie, psnr, session_with, tmp_dir};-use crate::relink::{apply_remap, derive_remap, index_folder};+#[cfg(unix)]+use crate::relink::index_folder;+use crate::relink::{apply_remap, derive_remap}; const W: u32 = 160; const H: u32 = 90;